History of the Issue:
This issue has existed since at least ES 1.2 beta, perhaps since the beginning of ES. I reported it way back and chatted with Jensen about it but there was so much stuff going on at the time that it was eventually forgotten. My post in issues disappeared hence why I didn't try bumping it. It took a lot of testing and playing around with things to figure out why the uploader was breaking. Jensen did attempt to address it at the time, but because it was so scenario dependent we got side tracked with other things.
The Problem:
The uploader fails to upload your selected photos when clicking "Add Photos". In addition to this, photos that are already uploaded over flow past the template as seen here (look closely on the right side):
The next time you try to upload photos without leaving the page, the uploader works just fine.
How to Replicate it
Set your screen resolution to 1280 x 1024. Then go to protostar's template.css file and add the following code that makes it a specific size:
Have an already existing album and try to add photos (if you need to create the album, refresh the page before uploading photos). Do not resize the window, and do not do anything else. After the upload fails, it seems to self correct itself and then allow uploading once the overflow is sized.
Another scenario where the uploader breaks is when you resize the window as the uploader is uploading photos.
The Why
Because we have an overflow issue in certain scenarios (sizing of screen vs template), the uploader literally breaks because the objects that are supposed to move the other photos cannot move. As a result screen resolution literally breaks functionality (this is the first time I've ever seen something like this).
Potential Solutions
- The self correcting mechanism that fixes the image width after it fails the first time could possibly have a method to get the right sizing the first time or run that little script as it loads.
- A way so that images can never overflow as seen in the above screen shot.
I just want to remind the stacked team that I'm highly appreciative of this awesome uploader and that this post is not meant in any way to be a complaint. It's a series of observations and to carefully address an issue.
This issue has existed since at least ES 1.2 beta, perhaps since the beginning of ES. I reported it way back and chatted with Jensen about it but there was so much stuff going on at the time that it was eventually forgotten. My post in issues disappeared hence why I didn't try bumping it. It took a lot of testing and playing around with things to figure out why the uploader was breaking. Jensen did attempt to address it at the time, but because it was so scenario dependent we got side tracked with other things.
The Problem:
The uploader fails to upload your selected photos when clicking "Add Photos". In addition to this, photos that are already uploaded over flow past the template as seen here (look closely on the right side):
The next time you try to upload photos without leaving the page, the uploader works just fine.
How to Replicate it
Set your screen resolution to 1280 x 1024. Then go to protostar's template.css file and add the following code that makes it a specific size:
.container {
max-width: 1280px !important;
width: 98% !important;
box-sizing: border-box;
}
.container, .navbar-static-top .container, .navbar-fixed-top .container, .navbar-fixed-bottom .container {
max-width: 1280px !important;
width: 98% !important;
}Have an already existing album and try to add photos (if you need to create the album, refresh the page before uploading photos). Do not resize the window, and do not do anything else. After the upload fails, it seems to self correct itself and then allow uploading once the overflow is sized.
Another scenario where the uploader breaks is when you resize the window as the uploader is uploading photos.
The Why
Because we have an overflow issue in certain scenarios (sizing of screen vs template), the uploader literally breaks because the objects that are supposed to move the other photos cannot move. As a result screen resolution literally breaks functionality (this is the first time I've ever seen something like this).
Potential Solutions
- The self correcting mechanism that fixes the image width after it fails the first time could possibly have a method to get the right sizing the first time or run that little script as it loads.
- A way so that images can never overflow as seen in the above screen shot.
I just want to remind the stacked team that I'm highly appreciative of this awesome uploader and that this post is not meant in any way to be a complaint. It's a series of observations and to carefully address an issue.