Komento with onesignal adds manifest.json
By shoulders on Friday, 09 March 2018
Posted in Technical Issues
Likes 0
Views 0.9K
Votes 0
Komento uses and adds manifest.json


<link rel="manifest" href="/manifest.json">


I already declare and use site.manifest which is the new web standard.


<link rel="manifest" href="/site.manifest">


I appreciate that onesignal is still using manifest.json see this github post but I need to turn this off as it will mess up other services such as my favicons.

I need this to be removed or an ability for me to turn it off.

NB: I dont think easy blogs adds this header.

Komento v3.0.11

thanks
Added a ticket for this internally to insert a new settings for manifest.json in EasyBlog.
Mark
·
Saturday, 10 March 2018 15:41
·
0 Likes
·
0 Votes
·
0 Comments
·
Komento doesn't add such tags on the page. It only adds the scripts on the page which can be found at /components/com_komento/themes/wireframe/push/onesignal.js
Mark
·
Friday, 09 March 2018 22:58
·
0 Likes
·
0 Votes
·
0 Comments
·
The line might get added with the onesignal js. If you are happy that is what is happening I will report it with them over at onesignal.

With Komento onesignal enabled:


</script>

	<script src="/media/com_komento/scripts/site-3.0.12.min.js"></script>

	<link rel="manifest" href="/manifest.json">



    <!--[if (gte IE 8)&(lte IE 9)]>

        <script type="text/javascript" src="/media/gantry5/assets/js/html5shiv-printshiv.min.js?5aa29634"></script>

        <link rel="stylesheet" href="/media/gantry5/engines/nucleus/css/nucleus-ie9.css?5aa29635" type="text/css"/>

        <script type="text/javascript" src="/media/gantry5/assets/js/matchmedia.polyfill.js?5aa29634"></script>

        <![endif]-->

                        <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">

<link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">

<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">


komento onesignal disabled


	"direction": "ltr"

};

</script>

	<script src="/media/com_easyblog/scripts/site-5.1.15.min.js"></script><script type="text/javascript" charset="UTF-8" src="https://quantumwarp.com/media/com_easyblog/scripts/vendors/ui/position.min.js"></script>



    <!--[if (gte IE 8)&(lte IE 9)]>

        <script type="text/javascript" src="/media/gantry5/assets/js/html5shiv-printshiv.min.js?5aa29634"></script>

        <link rel="stylesheet" href="/media/gantry5/engines/nucleus/css/nucleus-ie9.css?5aa29635" type="text/css"/>

        <script type="text/javascript" src="/media/gantry5/assets/js/matchmedia.polyfill.js?5aa29634"></script>

        <![endif]-->

                        <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">

<link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">

<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">
shoulders
·
Friday, 09 March 2018 23:17
·
0 Likes
·
0 Votes
·
0 Comments
·
Hm, I am guessing that onesignal's javascript file is adding them via their scripts because I can't locate anywhere within Komento that is adding the manifest.json.
Mark
·
Friday, 09 March 2018 23:34
·
0 Likes
·
0 Votes
·
0 Comments
·
I have found the word manifest 4 times and I think it is adding it via OneSignalSDK.js:



b = function() {

            function e() {}

            return e.fixWordpressManifestIfMisplaced = function() {

                var e = document.querySelectorAll("link[rel=manifest]");

                if (e && !(e.length <= 1))

                    for (var t = 0; t < e.length; t++) {

                        var n = e[t],

                            i = n.href;

                        p.contains(i, "gcm_sender_id") && (document.querySelector("head").insertBefore(n, document.querySelector("head").children[0]), r.info("OneSignal: Moved the WordPress push <manifest> to the first element in <head>."))

                    }

            }, e.getNotificationTypeFromOptIn = function(e) {

                return 1 == e || null == e ? 1 : -2

            }, e.wasHttpsNativePromptDismissed = function() {

                return "dismissed" === v.default.getItem("onesignal-notification-prompt")

            }, e.markHttpPopoverShown = function() {

                sessionStorage.setItem("ONESIGNAL_HTTP_PROMPT_SHOWN", "true")

            }, e.isHttpPromptAlreadyShown = function() {

                return "true" == sessionStorage.getItem("ONESIGNAL_HTTP_PROMPT_SHOWN")

            }, e.checkAndTriggerNotificationPermissionChanged = function() {

                Promise.all([g.default.get("Options", "notificationPermission"), OneSignal.getNotificationPermission()]).then(function(e) {

                    var t = e[0],

                        n = e[1];

                    t !== n && h.default.triggerNotificationPermissionChanged().then(function() {

                        return g.default.put("Options", {

                            key: "notificationPermission",

                            value: n

                        })

                    })

                })
shoulders
·
Friday, 09 March 2018 23:42
·
0 Likes
·
0 Votes
·
0 Comments
·
I would like to add that I have done a hard refresh on onesignalsdk.js and manifest.json is not getting aded anymore. I will look into this further and keep an eye out.

Also easyblog (onesignal script) was possibly not adding manifest.json because of load order on the page?

This issue report might of been to do with that https://github.com/OneSignal/OneSignal-Website-SDK/issues/332
shoulders
·
Saturday, 10 March 2018 00:05
·
0 Likes
·
0 Votes
·
0 Comments
·
EasyBlog will only add the manifest.json on the page if you did not enter any subdomain, http://take.ms/9BLY0 . The manifest.json is only required when you are trying to serve your site with https without the use of the subdomain from onesignal
Mark
·
Saturday, 10 March 2018 00:10
·
0 Likes
·
0 Votes
·
0 Comments
·
aah it is Easyblog, just checked and it is back

I do not use a onesignal subdomain because my website uses https (like most people now) but I do not use manifest.json I use site.webmanifest the newer standard.

Why does Komento not add this?

Possible solutions

Is it possible to either add an option (on/off) for this or add a further boolean check for rel="manifest" + notes in the documentation saying that easyblog will add manifest.json if no manifest exists.
shoulders
·
Saturday, 10 March 2018 00:29
·
0 Likes
·
0 Votes
·
0 Comments
·
thanks for your help
shoulders
·
Saturday, 10 March 2018 17:13
·
0 Likes
·
0 Votes
·
0 Comments
·
You are most welcome
Mark
·
Saturday, 10 March 2018 21:20
·
0 Likes
·
0 Votes
·
0 Comments
·
View Full Post