By Josh Lewis on Sunday, 21 September 2014
Posted in General Issues
Replies 3
Likes 0
Views 586
Votes 0
When opening an image via the popbox method I found the following code:

<b data-threshold="128" data-mode="contain">
<img data-height="" data-width="" data-large-src="http://www.alpineascent.com/media/com_easysocial/photos/1/39/p1040701_large.jpg" data-featured-src="http://www.alpineascent.com/media/com_easysocial/photos/1/39/p1040701_featured.jpg" data-thumbnail-src="http://www.alpineascent.com/media/com_easysocial/photos/1/39/p1040701_thumbnail.jpg" src="http://www.alpineascent.com/media/com_easysocial/photos/1/39/p1040701_large.jpg" data-photo-image="" style="max-height: 459px;">
</b>


While functionality this isn't a big deal at all, but semantically I think this is improper. Another interesting case is for the photo pages themselves which use:

<em data-photo-image-css="" style="background-image: url('http://www.alpineascent.com/media/com_easysocial/photos/1/39/p1040701_large.jpg');" class="es-photo-image"></em>


Because the img tag is loaded above, as far as I understand this code is not needed and can be taken out completely. Unless there's something I'm missing. Again, you guys did great with it's functionality, just wanting to use the best practices.
Hello Josh,

There's other reasons why it actually has to be wrapped in a specific tag but I need to check with Jensen about this. If I recall correctly, it was due to some IE compatibility purpose.
·
Sunday, 21 September 2014 14:06
·
0 Likes
·
0 Votes
·
0 Comments
·
Let me know what he says. Oh IE, the head ache browser.
·
Sunday, 21 September 2014 14:38
·
0 Likes
·
0 Votes
·
0 Comments
·
Yeah, erratic browser
·
Sunday, 21 September 2014 18:30
·
0 Likes
·
0 Votes
·
0 Comments
·
View Full Post