Hey Josh, I've been reviewing the resizing process while overhauling the image processor in EasySocial (not slated for 1.3 not sure when it will see the light of day).

There might be something I can bring in quickly for 1.2. I'll update you on this in a bit once I get the other issue on the other thread resolved.

Thanks Jensen, the photo quality increase will mean a lot to me. Not just a casual fix that makes me happy for a moment. (although smaller fixes go appreciated too) I get excited when I see new minor releases of ES now.

I really appreciate the effort on this, I feel that we are close on cracking this case. Unfortunately when I upload any photos it says "HTTP Error." regardless to the size. Here is what it looks like:



You can replicate the issue here: http://www.test.alpineascent.com/galleries/item/48-mount-rainier-may-2014/user/josh
Let me know if there is any server info that you need, or other configurations.

Hey Josh, the error was:
"Asido driver file "administrator/components/com_easysocial/includes/image/adapters/asido/class.driver.gd_hack.php" (for driver "gd_hack")" not found.
I'll get into the FTP to verify if the file exists hold on :-)

Turns out the file wasn't extracted Josh. Give it a spin.

Wow! It looks so much better now. The quality is now exactly where I want it to be. Now it's looking good as seen here:



Thanks Jensen, I really appreciate this fix.

You're welcome.

Image quality has been an issue since the beginning for me too, and is the single most important thing that prevents me to go live with my project (apart from other things as choosing a theme I like or making it myself). And quality is not just a question of compression: quality set to 100 is not the solution, as you would get files bigger than originals; quality is also a matter of color. GD is BAD! It messes up details and colours.
Mark said, in response to one of my posts here, that they would do something to fix image quality issue by adopting a new image engine or something similar. I myself suggested many times Image Magick and Mark was quite positive with that (He said that in 1.3 they would have done something nice with Image Magick).
Now you say "... overhauling the image processor is not slated for 1.3 not sure when it will see the light of day".

I'm happy with ES, even though I purchased version 1.0 with the promise of monthly updates (and after 6 months we only got 1.2), but I'm ok with that and with bi-monthly updates, I know that good software needs time and, again, I'm perfectly ok with that. But how long should I wait for this issue to be fixed?

I digged into the code (I'm not a programmer, my knowledge of php is very limited) and I found that your current image adapter supports a few GD implementations and Image Magick too, it just needs to be tweaked and tell the system to use one instead of the other. Can someone help me in doing that while we all wait for a more complete "image adapter overhauling" ?

Hello Antonio, I'm sorry to may have mentioned it that way in my previous post, here's a clearer explanation of what's going on.

ImageMagick is part of the overhaul and while it is true it was initially targeted for the 1.3 milestone, I have been now tasked to handle certain rewrites of EasyBlog 4.0 as well, which has well, forced me (in a good way) to release bits and pieces of the overhaul over the course of all these minor version releases throughout 1.2 and 1.3.

So it will now start with pure image tags and small image handling for 1.2.11, and one or two more image layout configuration for 1.2.12 and we'll see what goes out as we go along. :-)

I hope that is okay for you.

Ok, I will wait, given that I can't do otherwise.

In the meanwhile, can anyone help me with this tweaking?

I'm trying to do a bit of a hacking as I already did elsewhere, that is forcing the image adapter to load an icc profile and write it into the file. I did this with timthumb ad it works perfectly. I'm sure it can be done here too but I get errors; there must be something I do wrong.

This is the code to be inserted.

require_once('class.jpeg_icc.php'); - THIS is inserted at the beginning of the adapter and loads the class that does what I said.

This following code loads the profile and writes it into the file. $source_file is an image from which the icc profile is loaded. This is fine and works.
$destination_file is the file to be written, I think this should be a variable as $tmp->target, but it does not work.

$icc = new JPEG_ICC();
$icc->LoadFromJPEG($source_file);
$icc->SaveToJPEG($destination_file);

This is where the image adapter writes the image (where Jensen did the tweaking that already achieved better quality).
case 'image/jpeg' :
ob_start();
imageJPEG( $tmp->target, null, ASIDO_GD_JPEG_QUALITY );
$contents = ob_get_contents();
ob_end_clean();
break;

Question is: where to insert and how to fix those 3 lines of code to make it work?

Hey Antonio, great ICC lib!

I made an untested hack for you. I think you can work from there.
http://screencast.com/t/moPGmuyjxxG
http://screencast.com/t/LCJQ2bwguT

OH MY!!!!!!! I COULD CRY!!!!!!!! IT WORKS!!!!!!!!

THANK YOU JENSEN!!!!

@Antonio Pleasure is all mine~