.Issue on Event Date in Event Reminder Email
By Altitudes on Monday, 07 March 2016
Posted in Technical Issues
Likes 0
Views 564
Votes 0
Hello

As you can see in the attached snapshot (event reminder email), when there is no end date for an event, we have an issue.

Also, I think you should add the time in the date, because this is an important information and because for events happening within a day, "From 05-03-2016 10:00 to 05-03-2016 11:00" will look more friendly than "From 05-03-2016 to 05-03-2016"

Of course you could do more improvements so that the date renders well in all cases (all day events etc.). It's up to you.

One more thing: why don't you link to the events page (on bottom button)? Links in other ES notification emails are more relevant than that!

Thanks

.Fixed partially in ES 1.4.8
I checked your files. events.php is OK, but upcoming.reminder.event.php is not correct for all day event dates.
Here is the code I suggest (I have not tested it so be sure to check the syntax carefully).
Altitudes
·
Wednesday, 09 March 2016 03:14
·
0 Likes
·
0 Votes
·
0 Comments
·
Hey there,

I am sorry for the delay of this reply,

Can you try download my attached file and replace into JoomlaFolder\components\com_easysocial\themes\wireframe\emails\html\event\upcoming.reminder.event.php and see how it goes?

One more thing: why don't you link to the events page (on bottom button)? Links in other ES notification emails are more relevant than that!

Currently it link to Easysocial login page when you click on that bottom button from the remind email?
Arlex Wong
·
Monday, 07 March 2016 18:06
·
0 Likes
·
0 Votes
·
0 Comments
·
Hello

I have read you code and it looks nice
As I am not able to test it for now, I just have one question: what will be the output of
ES::date($event->start)->toFormat('d-m-Y H:i');

if you have no time (all day event)? If this is 05-03-2016 00:00 then we have an issue (time should not appear).

Currently it link to Easysocial login page when you click on that bottom button from the remind email?

Yes. Linking to the events page would be more appropriate.
Altitudes
·
Monday, 07 March 2016 19:26
·
0 Likes
·
0 Votes
·
0 Comments
·
Also if the screenshot has the default language string.. it has a typo 'participanting'

Really it should also be event(s) and participating in on that top line too...

..Hopefully those are easy tweaks for the next ES version (which hopefully is due soon - seems to have been lots of little bugs fixed lately - nice work SI team!)
Andy
·
Monday, 07 March 2016 23:34
·
0 Likes
·
0 Votes
·
0 Comments
·
Hey Altitudes,

I am sorry for the delay of this reply,


I have read you code and it looks nice
As I am not able to test it for now, I just have one question: what will be the output of
ES::date($event->start)->toFormat('d-m-Y H:i');

if you have no time (all day event)? If this is 05-03-2016 00:00 then we have an issue (time should not appear).

Yes, it will use this format -> 05-03-2016 00:00 , and I also add a checking if the event didn't set end date, so this event will consider is all day event, then it will show the start date.

Yes. Linking to the events page would be more appropriate.

Try download my attached file and replace into JoomlaFolder\administrator\components\com_easysocial\models\events.php and see how it goes.

=================================================================================
Hey Andy,

Thanks for heading up on this, I will fix these typo string in next release version.

But I have a little bit lost regarding this :
Really it should also be event(s) and participating in on that top line too...

Perhaps you can provide more info which part you referring from the above screenshot?
Arlex Wong
·
Tuesday, 08 March 2016 16:15
·
0 Likes
·
0 Votes
·
0 Comments
·
Thank you. I will test the new file you provided shortly.

Regarding the date for all day events (start and/or end date), it should not contain 00:00 time. An all day event is NOT a event starting at midnight it's an event with no time.

Regarding Andy suggestion, he just meant that in addition to the typo the following corrections should be done (in bold):

"Relax! This is a system reminder for the upcoming event(s) that you're participating in."
Altitudes
·
Tuesday, 08 March 2016 17:24
·
0 Likes
·
0 Votes
·
0 Comments
·
Oh ya, that was correct
Then you have to download this latest fix file at here and replace into
JoomlaFolder\components\com_easysocial\themes\wireframe\emails\html\event\upcoming.reminder.event.php and see how it goes.

Regarding Andy suggestion, he just meant that in addition to the typo the following corrections should be done (in bold):

"Relax! This is a system reminder for the upcoming event(s) that you're participating in."

Thanks for described again.
Arlex Wong
·
Tuesday, 08 March 2016 17:47
·
0 Likes
·
0 Votes
·
0 Comments
·
Yes that's what I meant (as clarified by Altitudes above). Thanks to you both!
Andy
·
Tuesday, 08 March 2016 20:55
·
0 Likes
·
0 Votes
·
0 Comments
·
Hey Altitudes,

Thanks for sharing, I've checked your code, the syntax all fine.
Arlex Wong
·
Wednesday, 09 March 2016 10:25
·
0 Likes
·
0 Votes
·
0 Comments
·
I think the change you did to my code is not correct. $event->end == '0000-00-00 00:00:00' is an event with no end date, it is not equivalent to $event->all_day.

Note that an all day event can last several days, so we need to use COM_EASYSOCIAL_EMAILS_UPCOMING_REMINDER_ON or COM_EASYSOCIAL_EMAILS_UPCOMING_REMINDER_FROM_TO depending on the case.
Altitudes
·
Wednesday, 09 March 2016 20:53
·
0 Likes
·
0 Votes
·
0 Comments
·
Thanks for corrected.
Arlex Wong
·
Thursday, 10 March 2016 15:46
·
0 Likes
·
0 Votes
·
0 Comments
·
You are welcome

So I guess this will be included in next ES release?
Altitudes
·
Thursday, 10 March 2016 16:57
·
0 Likes
·
0 Votes
·
0 Comments
·
Yes, I already commit this fix in our repo, and it will included in next release version.

As a gentle reminder, kindly start a new thread if you have any other issue in the future so it will be easier for us to manage your inquiry. I will lock and mark this thread as resolved.
Arlex Wong
·
Friday, 11 March 2016 11:29
·
0 Likes
·
0 Votes
·
0 Comments
·
View Full Post